Update topics repo count when deleting repository#10051
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10051 +/- ##
==========================================
- Coverage 42.29% 42.29% -0.01%
==========================================
Files 619 619
Lines 80879 80879
==========================================
- Hits 34211 34210 -1
- Misses 42458 42461 +3
+ Partials 4210 4208 -2
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
6543
reviewed
Jan 29, 2020
lunny
reviewed
Jan 29, 2020
Member
Author
|
@lunny @guillep2k updated to single update command using xorm builder. FYI: |
guillep2k
approved these changes
Jan 30, 2020
| "`repo_count`": builder.Select("count(*)").From("`repo_topic`").Where(builder.Eq{ | ||
| "`repo_topic`.`topic_id`": builder.Expr("`topic`.`id`"), | ||
| }), | ||
| }).From("`topic`").Where(builder.Eq{"'1'": "1"})) |
Member
Author
There was a problem hiding this comment.
I just wanted to see if it can be done 😆
GiteaBot
added
lgtm/need 1
zeripath
approved these changes
Jan 30, 2020
GiteaBot
added
lgtm/done
6543
approved these changes
Jan 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10038